Skip to content

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Dec 11, 2025

Translations update from LycheeOrg - Weblate for Lychee/aspect_ratio.

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • Localization
    • Updated Russian language translations for gallery statistics including share counts and favorites, improving the experience for Russian-speaking users.

✏️ Tip: You can customize this high-level summary in your review settings.

NikitaTH and others added 2 commits December 11, 2025 22:15
Currently translated at 98.9% (190 of 192 strings)

Translation: Lychee/gallery
Translate-URL: http://weblate.lycheeorg.dev/projects/lycheeorg/gallery/ru/
Currently translated at 98.9% (190 of 192 strings)

Translation: Lychee/gallery
Translate-URL: http://weblate.lycheeorg.dev/projects/lycheeorg/gallery/ru/
@ildyria ildyria requested a review from a team as a code owner December 11, 2025 22:15
@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025

📝 Walkthrough

Walkthrough

This change updates Russian language translations in the gallery module. Three UI stat field labels were changed from English placeholders to their Russian equivalents: "Number of shares" and "Number of favourites". The modifications affect album and photo statistics displays with no structural or logic changes.

Changes

Cohort / File(s) Summary
Russian Gallery Translations
lang/ru/gallery.php
Updated three translation strings from English to Russian: "Number of shares" → "Кол-во поделившихся" (album and photo stats), "Number of favourites" → "Кол-во избранных" (photo stats)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify Russian translations are accurate and idiomatic
  • Confirm all translation keys match their intended UI contexts

Poem

🐰 In galleries fair, where photos dance bright,
Russian words bloom, now perfectly right,
Shares and favorites dressed in Cyrillic cheer,
By CodeRabbit's touch—translations crystal clear! ✨

Pre-merge checks

✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8af0d4e and e153333.

📒 Files selected for processing (1)
  • lang/ru/gallery.php (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.php

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.php: Any new PHP file should contain the license header and have a single blank line after the opening PHP tag
Variable names should be in snake_case
Apply PSR-4 coding standard
in_array() should be used with true as the third parameter for strict comparison
Only use booleans in if statements, not integers or strings
Use strict comparison (===) instead of loose comparison (==)
Avoid code duplication in both if and else statements
Do not use empty()
Use the moneyphp/money library for handling monetary values and currencies in PHP
Never use floats or doubles to represent monetary values; use integers to represent the smallest currency unit (e.g., cents for USD)

Files:

  • lang/ru/gallery.php
🧠 Learnings (2)
📓 Common learnings
Learnt from: ildyria
Repo: LycheeOrg/Lychee PR: 3641
File: lang/no/settings.php:9-9
Timestamp: 2025-08-22T06:11:18.329Z
Learning: For lang/* translation files in the Lychee project: only review PHP-related issues (syntax, structure, etc.), not translation content, grammar, or language-related nitpicks. The maintainer ildyria has explicitly requested this approach.
Learnt from: ildyria
Repo: LycheeOrg/Lychee PR: 3654
File: lang/pl/gallery.php:210-210
Timestamp: 2025-08-27T08:48:32.956Z
Learning: The user ildyria does not prioritize strict localization consistency for new menu items in language files, as indicated by their "Lang = don't care" response when suggested to translate 'Import from Server' to Polish in lang/pl/gallery.php.
📚 Learning: 2025-08-27T08:48:32.956Z
Learnt from: ildyria
Repo: LycheeOrg/Lychee PR: 3654
File: lang/pl/gallery.php:210-210
Timestamp: 2025-08-27T08:48:32.956Z
Learning: The user ildyria does not prioritize strict localization consistency for new menu items in language files, as indicated by their "Lang = don't care" response when suggested to translate 'Import from Server' to Polish in lang/pl/gallery.php.

Applied to files:

  • lang/ru/gallery.php
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: 3️⃣ PHP dist / 8.3 - sqlite
  • GitHub Check: 3️⃣ PHP dist / 8.3 - postgresql
  • GitHub Check: 3️⃣ PHP dist / 8.4 - mariadb
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Webshop
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Install
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- ImageProcessing
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Unit
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Webshop
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- ImageProcessing
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Install
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.4 - mariadb -- Install
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Install
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Unit
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Webshop
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- ImageProcessing
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Unit
🔇 Additional comments (1)
lang/ru/gallery.php (1)

91-101: PHP array structure and syntax remain valid

The modified entries under album['stats'] and photo['details']['stats'] only change string values; keys, commas, and array delimiters are intact and form valid PHP. No structural or syntax issues from these changes. Based on learnings, I have not reviewed the translation wording itself.

Also applies to: 160-166


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ildyria ildyria merged commit aea38d1 into master Dec 11, 2025
45 checks passed
@ildyria ildyria deleted the translations branch December 11, 2025 22:20
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.80%. Comparing base (8af0d4e) to head (e153333).
⚠️ Report is 31 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8af0d4e) and HEAD (e153333). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (8af0d4e) HEAD (e153333)
36 33
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria restored the translations branch January 1, 2026 12:17
@ildyria ildyria deleted the translations branch January 1, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants