Skip to content

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Nov 26, 2025

Translations update from LycheeOrg - Weblate for Lychee/aspect_ratio.

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • Localization
    • Enhanced French translations for embed configuration options, including spacing, row height, column width, and photo count settings.

✏️ Tip: You can customize this high-level summary in your review settings.

Currently translated at 84.7% (156 of 184 strings)

Translation: Lychee/dialogs
Translate-URL: http://weblate.lycheeorg.dev/projects/lycheeorg/dialogs/fr/
@ildyria ildyria requested a review from a team as a code owner November 26, 2025 23:34
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

📝 Walkthrough

Walkthrough

French translation updates applied to embed code layout options in lang/fr/dialogs.php. Five translation entries modified: spacing, row height, column width, maximum photos count, and the "none/all photos" option label. No logic or structural changes.

Changes

Cohort / File(s) Change Summary
French Embed Code Translations
lang/fr/dialogs.php
Updated five French translations for embed code layout section: spacing ("Spacing" → "Espacement"), row height ("Row Height" → "Hauteur de ligne"), column width ("Column Width" → "Largeur de colonne"), max photos ("Maximum Photos" → "Nombre maximum de photos"), and max photos none label ("None (all photos)" → "Aucun (toutes les photos)")

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Translation strings only; verify French accuracy and consistency with existing translation conventions

Poem

🐰 Hopping through phrases, left to right,
French words polished, translations bright,
Espacement, hauteur, largeur divine—
Every embedding option now doth shine!

Pre-merge checks

✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f5ef22 and 323f27c.

📒 Files selected for processing (1)
  • lang/fr/dialogs.php (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.php

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.php: Any new PHP file should contain the license header and have a single blank line after the opening PHP tag
Variable names should be in snake_case
Apply PSR-4 coding standard
in_array() should be used with true as the third parameter for strict comparison
Only use booleans in if statements, not integers or strings
Use strict comparison (===) instead of loose comparison (==)
Avoid code duplication in both if and else statements
Do not use empty()
Use the moneyphp/money library for handling monetary values and currencies in PHP
Never use floats or doubles to represent monetary values; use integers to represent the smallest currency unit (e.g., cents for USD)

Files:

  • lang/fr/dialogs.php
🧠 Learnings (1)
📓 Common learnings
Learnt from: ildyria
Repo: LycheeOrg/Lychee PR: 3641
File: lang/no/settings.php:9-9
Timestamp: 2025-08-22T06:11:18.329Z
Learning: For lang/* translation files in the Lychee project: only review PHP-related issues (syntax, structure, etc.), not translation content, grammar, or language-related nitpicks. The maintainer ildyria has explicitly requested this approach.
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: 3️⃣ PHP dist / 8.4 - sqlite
  • GitHub Check: 3️⃣ PHP dist / 8.4 - mariadb
  • GitHub Check: 3️⃣ PHP dist / 8.3 - mariadb
  • GitHub Check: 3️⃣ PHP dist / 8.4 - postgresql
  • GitHub Check: 3️⃣ PHP dist / 8.3 - sqlite
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Install
  • GitHub Check: 2️⃣ PHP tests / 8.4 - sqlite -- Install
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- ImageProcessing
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- ImageProcessing
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Unit
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- ImageProcessing
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Install
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Webshop
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Webshop
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Unit
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Unit
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Webshop
🔇 Additional comments (1)
lang/fr/dialogs.php (1)

87-91: LGTM! PHP syntax is correct.

The translation updates follow proper PHP array syntax with correct string delimiters and formatting. No structural or syntax issues detected.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (8f5ef22) to head (323f27c).
⚠️ Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit 5013a32 into master Nov 27, 2025
48 checks passed
@ildyria ildyria deleted the translations branch November 27, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants