Skip to content

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Sep 15, 2025

Translations update from LycheeOrg - Weblate for Lychee/aspect_ratio.

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • Localization
    • Improved Norwegian translations on the landing page: “Access the gallery,” “Powered by Lychee,” and copyright notice updated to native phrasing.
    • Updated left menu labels to Norwegian: “Frame” → “Ramme,” “Map” → “Kart,” “Admin” → “Administrator.”
    • No changes to keys or structure; only text updated for clearer, more consistent Norwegian user experience.

Currently translated at 100.0% (4 of 4 strings)

Translation: Lychee/landing
Translate-URL: http://weblate.lycheeorg.dev/projects/lycheeorg/landing/nb_NO/
Currently translated at 26.6% (4 of 15 strings)

Translation: Lychee/left-menu
Translate-URL: http://weblate.lycheeorg.dev/projects/lycheeorg/left-menu/nb_NO/
@ildyria ildyria requested a review from a team as a code owner September 15, 2025 00:31
@coderabbitai
Copy link

coderabbitai bot commented Sep 15, 2025

📝 Walkthrough

Walkthrough

Updated Norwegian localization strings in two files: landing page and left menu. Only translation values changed; keys and structure unchanged. No logic or exported/public declarations modified.

Changes

Cohort / File(s) Summary
Norwegian localization updates
lang/no/landing.php, lang/no/left-menu.php
Revised English-to-Norwegian translations for landing page entries (access_gallery, Powered_by_Lychee, copyright) and left menu items (frame, map, admin). No keys added/removed; structure and logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny hops through fields of Å and Ø,
Polishing menus where nordic breezes blow.
Buttons now whisper “Kart” and “Ramme” true,
The gallery door says “Velkommen” to you.
I twitch my nose—språk all tidy and neat,
Translations done—what a linguistic treat! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Translations update from LycheeOrg - Weblate" succinctly and accurately describes the primary change — a translations import/update from Weblate for the Lychee project — which matches the modified Norwegian translation files in the changeset; it is concise, relevant, and gives reviewers a correct high-level expectation.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch translations

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between abb262b and ec47bcc.

📒 Files selected for processing (2)
  • lang/no/landing.php (1 hunks)
  • lang/no/left-menu.php (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.php

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.php: New PHP files must include the project license header and have a single blank line after the opening <?php tag
Use snake_case for PHP variable names
Apply PSR-4 coding standard to PHP code
Always call in_array with true as the third parameter for strict checking (in_array($needle, $haystack, true))
Only use boolean expressions in if statements; avoid integers or strings as conditions
Use strict comparison (===, !==) instead of loose comparison (==, !=)
Avoid duplicating code in both if and else branches
Do not use empty(); prefer explicit checks (e.g., === null, === '', count(...) === 0)

Files:

  • lang/no/left-menu.php
  • lang/no/landing.php
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: 3️⃣ PHP dist / 8.4 - sqlite
  • GitHub Check: 3️⃣ PHP dist / 8.4 - postgresql
  • GitHub Check: 3️⃣ PHP dist / 8.3 - sqlite
  • GitHub Check: 3️⃣ PHP dist / 8.4 - mariadb
  • GitHub Check: 3️⃣ PHP dist / 8.3 - mariadb
  • GitHub Check: 3️⃣ PHP dist / 8.3 - postgresql
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.4 - sqlite -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.4 - mariadb -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.4 - postgresql -- Unit,Feature_v2
🔇 Additional comments (2)
lang/no/left-menu.php (1)

10-12: LGTM: Updated Norwegian menu labels are correct and consistent.

Keys unchanged; values read naturally (“Ramme”, “Kart”, “Administrator”).

lang/no/landing.php (1)

9-11: LGTM: Landing translations look good; placeholders preserved.

%1$s and %2$s kept intact; wording is natural (“Få tilgang…”, “Drevet av Lychee”).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (abb262b) to head (ec47bcc).
⚠️ Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit 5dce2f0 into master Sep 15, 2025
36 checks passed
@ildyria ildyria deleted the translations branch September 15, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants