Skip to content

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Sep 8, 2025

Translations update from LycheeOrg - Weblate for Lychee/aspect_ratio.

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • New Features

    • Updated Norwegian translations for search UI in the gallery, including title, placeholder, and no-results message, improving the experience for Norwegian users.
  • Style

    • Minor indentation adjustment in a menu entry; no functional changes.

Currently translated at 6.4% (12 of 187 strings)

Translation: Lychee/gallery
Translate-URL: http://weblate.lycheeorg.dev/projects/lycheeorg/gallery/nb_NO/
@ildyria ildyria requested a review from a team as a code owner September 8, 2025 19:34
@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

📝 Walkthrough

Walkthrough

Norwegian localization strings in lang/no/gallery.php were updated for search-related UI text, and a minor indentation adjustment was made in the menus section without altering keys or values.

Changes

Cohort / File(s) Summary
Localization and formatting (NO)
lang/no/gallery.php
Updated search UI strings from English to Norwegian (title, no_results, searchbox). Adjusted indentation for the menus.import_server entry without changing its key or value. No changes to exported/public interfaces.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A whisk of whiskers, a hop of glee,
I nibbled on strings from EN to NO, see?
“Search” became “Søk,” so neat and bright,
With tidy tabs aligned just right.
Carrots for code, and paws that care—
Localization done with bunny flair! 🥕🐇

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  - Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
  - Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f881166 and 1bbe49e.

📒 Files selected for processing (1)
  • lang/no/gallery.php (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.php

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.php: New PHP files must include the project license header and have a single blank line after the opening <?php tag
Use snake_case for PHP variable names
Apply PSR-4 coding standard to PHP code
Always call in_array with true as the third parameter for strict checking (in_array($needle, $haystack, true))
Only use boolean expressions in if statements; avoid integers or strings as conditions
Use strict comparison (===, !==) instead of loose comparison (==, !=)
Avoid duplicating code in both if and else branches
Do not use empty(); prefer explicit checks (e.g., === null, === '', count(...) === 0)

Files:

  • lang/no/gallery.php
🧠 Learnings (2)
📓 Common learnings
Learnt from: ildyria
PR: LycheeOrg/Lychee#3641
File: lang/no/settings.php:9-9
Timestamp: 2025-08-22T06:11:18.329Z
Learning: For lang/* translation files in the Lychee project: only review PHP-related issues (syntax, structure, etc.), not translation content, grammar, or language-related nitpicks. The maintainer ildyria has explicitly requested this approach.
📚 Learning: 2025-08-27T08:48:32.956Z
Learnt from: ildyria
PR: LycheeOrg/Lychee#3654
File: lang/pl/gallery.php:210-210
Timestamp: 2025-08-27T08:48:32.956Z
Learning: The user ildyria does not prioritize strict localization consistency for new menu items in language files, as indicated by their "Lang = don't care" response when suggested to translate 'Import from Server' to Polish in lang/pl/gallery.php.

Applied to files:

  • lang/no/gallery.php
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: 3️⃣ PHP dist / 8.3 - postgresql
  • GitHub Check: 3️⃣ PHP dist / 8.4 - postgresql
  • GitHub Check: 3️⃣ PHP dist / 8.4 - mariadb
  • GitHub Check: 3️⃣ PHP dist / 8.4 - sqlite
  • GitHub Check: 3️⃣ PHP dist / 8.3 - mariadb
  • GitHub Check: 3️⃣ PHP dist / 8.3 - sqlite
  • GitHub Check: 2️⃣ PHP tests / 8.4 - mariadb -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.4 - sqlite -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.4 - postgresql -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - mariadb -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - postgresql -- Unit,Feature_v2
  • GitHub Check: 2️⃣ PHP tests / 8.3 - sqlite -- Unit,Feature_v2
🔇 Additional comments (2)
lang/no/gallery.php (2)

31-33: PHP structure unchanged; safe string-only updates.

Only values changed; keys and placeholders remain intact. Array syntax and return semantics are valid.


210-210: Whitespace-only tweak; no functional impact.

Indentation change does not affect the array. Key and value unchanged.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch translations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (f881166) to head (1bbe49e).
⚠️ Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit 9eb49d8 into master Sep 8, 2025
36 checks passed
@ildyria ildyria deleted the translations branch September 8, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants