Apply home current language to terms page #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay! (You know why) Initial read through: this looks very clean, I just have to try it out (assigning to me to do so, when I am able)
This makes sense, and it prevents people from inadvertently changing their default language selection. Thank you very much @goodolcuppa , and again apologies for the delay. |
|
@goodolcuppa - small lint error. I'll re-run the PR to check the base-ci, it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the current language filter from home page to the terms page
Closes #326
Uses the same value as home for the terms language filter. Changing the value on the terms page will not update the stored value, so on refresh, this will revert back to whichever value is set on the home page