Skip to content

Change dictionary javascript structure used by UI, dicttabs #331

@jzohrab

Description

@jzohrab

Currently, the dictionaries are given to the UI in a simple array like this (more or less)

[ "http://blah/###", "*http://blarg/###" ]

In issue #330, we'd also need to pass along the nickname, presumably something like this:

[ { url: "http://blah/###", nickname: "d1" }, { url: "*http://blarg/###", nickname: "d2" } ]

So as a prep. move for that, we should change the current dict structure to this:

[ { url: "http://blah/###" }, { url: "*http://blarg/###" } ]

and while doing that, we might as well get rid of that "*" character:

[ { url: "http://blah/###", dicttype: "embedded" }, { url: "http://blarg/###", dicttype: "popup" } ]

Sizing notes:

  • change existing dictionary structure returned by route
  • check everywhere that the dict struct is used
  • change dicttabs.js and stuff to work with existing
  • ensure sentence translation works (embedded and popup)
  • ensure page translation works (embedded? and popup)
  • ensure term dict tabs work

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions