Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads #159

Closed
wants to merge 6 commits into from
Closed

Threads #159

wants to merge 6 commits into from

Conversation

jtravs
Copy link
Contributor

@jtravs jtravs commented Apr 23, 2020

Basic threads attempt. It works, and gives a disappointing 24% speedup for 4 threads for radial free space sims.

I implemented this now because I was getting fed up of very slow modal simulations with vector plasma, but haven;t yet implemented modal threads.

  • Radial free space threads
  • Full free space threads
  • Get this working for modal sims
  • Benchmark xy sims too
  • Check tests pass with varying number of threads

Fixes #40

@chrisbrahms
Copy link
Collaborator

That you get such little improvement is probably at least partly because the Hankel transform itself takes up a significant chunk of the runtime (btw what version of Hankel are you using? I made it up to 8x faster from 0.2 to 0.2.1). Multithreading that is on my to-do list but not very high up right now.

@jtravs
Copy link
Contributor Author

jtravs commented Apr 24, 2020

Yes, it should be much better in the modal case, and also when the nonlinear part is much larger (e.g. Raman). But in fnfep even in the modal case the gains were not so huge. I just tried this now because, as you can see, the changes required were trivial.

@jtravs
Copy link
Contributor Author

jtravs commented Apr 27, 2020

Modal sims at least 2x faster with 4 threads. Still not great but on par with fnfep.

@jtravs
Copy link
Contributor Author

jtravs commented Aug 3, 2023

Why was this closed? It was working and still the correct approach I think, and was decently fast. It did need updating.

@chrisbrahms
Copy link
Collaborator

Ehh, no idea, didn't even realise that happened.

@chrisbrahms chrisbrahms mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multithreading
2 participants