-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threads #159
Threads #159
Conversation
That you get such little improvement is probably at least partly because the Hankel transform itself takes up a significant chunk of the runtime (btw what version of |
Yes, it should be much better in the modal case, and also when the nonlinear part is much larger (e.g. Raman). But in fnfep even in the modal case the gains were not so huge. I just tried this now because, as you can see, the changes required were trivial. |
Modal sims at least 2x faster with 4 threads. Still not great but on par with fnfep. |
…nse-and-threads
Why was this closed? It was working and still the correct approach I think, and was decently fast. It did need updating. |
Ehh, no idea, didn't even realise that happened. |
Basic threads attempt. It works, and gives a disappointing 24% speedup for 4 threads for radial free space sims.
I implemented this now because I was getting fed up of very slow modal simulations with vector plasma, but haven;t yet implemented modal threads.
Fixes #40