Skip to content

[#20] - Quick fix to the spotlight selection process - #21

Merged
LunarVagabond merged 2 commits into
developmentfrom
20-bug-spotlight-failed-selection
Jun 24, 2026
Merged

[#20] - Quick fix to the spotlight selection process#21
LunarVagabond merged 2 commits into
developmentfrom
20-bug-spotlight-failed-selection

Conversation

@LunarVagabond

@LunarVagabond LunarVagabond commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Related Issue: #20

Summary

Accepting the PR into the development branch will address the spotlight bug where we fail to pick a NEW repo of the week.

Changes

  • See Commits and PR Review.

Checklist

  • Tests added or updated
  • ruff check and black pass (backend)
  • vue-tsc --noEmit passes (frontend)
  • CHANGELOG.md updated under ## Unreleased
  • No new <style> blocks in .vue files

@LunarVagabond
LunarVagabond requested a review from Copilot June 24, 2026 16:09
@LunarVagabond LunarVagabond self-assigned this Jun 24, 2026
@LunarVagabond LunarVagabond added the bug Something isn't working label Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Addresses the “spotlight gap” issue where the daily safety-net sync could clear the previous Repo of the Week when the weekly selection task hasn’t produced a current-week pick, leaving the site without a spotlight.

Changes:

  • Add fallback logic in sync_spotlight_watches to use the most recent prior RepoOfTheWeek when the current week has no record.
  • Add test coverage to ensure the fallback preserves the previous spotlight selection.
  • Configure select_repo_of_week to retry on failures, and document the behavior in the changelog.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
CHANGELOG.md Documents the spotlight fallback and weekly task retry behavior under Unreleased → Fixed.
backend/apps/repositories/spotlight.py Prevents daily spotlight sync from clearing watches when there is no current-week pick by falling back to the most recent pick.
backend/apps/analysis/tests/test_tasks.py Adds a regression test ensuring the previous spotlight is preserved if the current-week pick is missing.
backend/apps/analysis/tasks.py Adds Celery retry configuration to the weekly select_repo_of_week task.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backend/apps/analysis/tasks.py
@LunarVagabond
LunarVagabond merged commit ff4709d into development Jun 24, 2026
1 check passed
@LunarVagabond
LunarVagabond deleted the 20-bug-spotlight-failed-selection branch June 24, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants