Skip to content

Optimize screenshots layer #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Optimize screenshots layer #2385

wants to merge 40 commits into from

Conversation

olehkuznetsov
Copy link

Screenshots are saved on another thread.

Support scaling.
Additional PAM file format.
Reuse created data for next screenshots.
Support for Android atrace profiling.

a bit of code refactoring.

olehkuznetsov and others added 24 commits May 2, 2025 14:36
@olehkuznetsov
Refactoring. Split determineOutputFormat from writePPM
f871d02
@olehkuznetsov
Refactoring. Split writeImageToFile from writePPM
bf3e3ed
@olehkuznetsov
Add semaphore to screenshot making queue
51fc479
@olehkuznetsov
Removed waiting for device and queue idle
216dfb7
@olehkuznetsov
Hardcode screenshot scale to be 1/8 of original size
a59d4ad
@olehkuznetsov
Basic atrace profiling
c016e92
@olehkuznetsov
Optimize writeImageToFile function
4871a8f
@olehkuznetsov
Move profile code inside screenshot namespace
43ea57c
@olehkuznetsov
Modify scaling to * instead /
b09495d
@olehkuznetsov
Move screenshot saving to separate thread
9871c63
@olehkuznetsov
Add more optimized writePAM which uses pam image format
6e5a8c3
@olehkuznetsov
Override vkDestroySwapChainKHR to wait for screenshots thread
afc008b
@olehkuznetsov
Use vkuFormatComponentCount to get dstNumChannels
1cbf498
@olehkuznetsov
Add profile counter to measure queue size
2b9756a
@olehkuznetsov
Add allowToSkipFrames
7713193
@olehkuznetsov
CMakeLists.txt remove duplicate header
35953a0
@olehkuznetsov
screenshot: remove global variable printFormatWarning
3587035
@olehkuznetsov
screenshot: Add settings class and add more settings
cde5a4e
@olehkuznetsov
Rename WritePPMCleanupData to ScreenshotQueueData
16dfc59
@olehkuznetsov
Unmap memory earilier
a390e1a
@olehkuznetsov
Reuse vulkan objects for next screenshot from the same source image
82e789f
@olehkuznetsov
refactor VkSubmitInfo
ef3ff66
@m--koma
Code format + remove unnecessary extension registration.
6df990a
@m--koma
Merge pull request #1 from olehkuznetsov/format
8ae0278 
Format code, update min Android version + a minor cleanup.
@ci-tester-lunarg
Copy link

Author olehkuznetsov not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented May 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ci-tester-lunarg
Copy link

Author olehkuznetsov not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

Author olehkuznetsov not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 447274.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 4487 running.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 4487 passed.

@ci-tester-lunarg
Copy link

Author olehkuznetsov not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

Author olehkuznetsov not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

Author olehkuznetsov not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg
Copy link

Author olehkuznetsov not on autobuild list. Waiting for curator authorization before starting CI build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olehkuznetsov @ci-tester-lunarg @CLAassistant @m--koma