Remove 0.0 when there is no trade, sams as monthly_heatmap_detailedview - #56
Open
twkim112 wants to merge 1 commit into
Open
Remove 0.0 when there is no trade, sams as monthly_heatmap_detailedview#56twkim112 wants to merge 1 commit into
twkim112 wants to merge 1 commit into
Conversation
|
My review is in progress 📖 - I will have feedback for you in a few minutes! |
There was a problem hiding this comment.
The code uses bare except clauses in a couple of places to catch all exceptions without specifying the exception type. This can make it difficult to identify and handle specific types of exceptions. Consider replacing the bare except clauses with specific exception types that you expect and want to handle, such as ValueError, KeyError, etc. This will make the exception handling more explicit and allow you to handle different exceptions appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
These changes align the behavior of the
monthly_heatmapfunction with themonthly_heatmap_detailedviewfunction.Here is sample figure with BTC's close data.
