Skip to content

Remove 0.0 when there is no trade, sams as monthly_heatmap_detailedview - #56

Open
twkim112 wants to merge 1 commit into
Lumiwealth:mainfrom
twkim112:main
Open

Remove 0.0 when there is no trade, sams as monthly_heatmap_detailedview#56
twkim112 wants to merge 1 commit into
Lumiwealth:mainfrom
twkim112:main

Conversation

@twkim112

@twkim112 twkim112 commented Aug 4, 2024

Copy link
Copy Markdown
Contributor

Changes:

  • Removed 0.0 when there is no trade in the monthly_heatmap function.
  • Added a mask to filter out 0.0 values.
  • Removed grid

These changes align the behavior of the monthly_heatmap function with the monthly_heatmap_detailedview function.

Here is sample figure with BTC's close data.
image

@korbit-ai

korbit-ai Bot commented Aug 4, 2024

Copy link
Copy Markdown

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category Error Handling

The code uses bare except clauses in a couple of places to catch all exceptions without specifying the exception type. This can make it difficult to identify and handle specific types of exceptions. Consider replacing the bare except clauses with specific exception types that you expect and want to handle, such as ValueError, KeyError, etc. This will make the exception handling more explicit and allow you to handle different exceptions appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant