-
Notifications
You must be signed in to change notification settings - Fork 81
Sqlite session store #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlite session store #497
Conversation
|
It looks like we are going in the right direction!
|
|
Done. I've used sqlite's memory store for the tests, for speed and to avoid permissions issues. Let me know if you'd prefer me to stick to using a file instead |
Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>
|
The happy path is well-covered by tests now. We should focus on testing the unhappy path:
You can invoke |
|
Good point, and I didn't know about llvm-cov thanks - coverage now at high 80s (from high 60s). Gonna do the same with the mysql implementation, now. |
|
/ok-to-test sha=c6bf07b |
Closes #465
Tries to follow the implementation for Postgres as close as possible.
TODO
update sessions installation guide (WIP - have yet to generate the tute to view it)Key Differences from PostgreSQL Implementation
JSONBJSONBUUIDTEXTTIMESTAMPTZ+jiff-sqlxINTEGER(Unix)(now() AT TIME ZONE 'UTC')unixepoch()$1, $2, $3?, ?, ?IF NOT EXISTSDELETE ... LIMITDELETE ... WHERE id IN (SELECT ... LIMIT)LIMITinDELETE"23505""1555"Usage
Files Added
libs/pavex_session_sqlx/src/sqlite.rs- Complete SQLite session store implementationlibs/pavex_session_sqlx/src/lib.rs- Export SQLite typeslibs/pavex_session_sqlx/Cargo.toml- Add SQLite feature