Add support for C_DeriveKey PKCS#11 function #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for CK_KEY_DERIVATION_STRING_DATA struct for use as mechanism parameters Add support for DUKPT key derivation Add support for ECIES encrypt/decrypt operations Note: For DUKPT and ECIES operations, underlying cryto implementation must support it otherwise CKR_MECHANISM_INVALID error is encountered.
Owner
|
It looks nice. Can yo provide a Unitary Test as the ones in the
|
Contributor
Author
|
I had created few unit tests. Unfortunately, for my use case mechanisms involved are not standard, thus, softhsm will not support it. |
Owner
|
Allo @balsingh1991, any progress on the use of SoftHSM with your patches? |
Contributor
Author
|
Hi,
My apologies for leaving this stray for long. I will check and report
sometime next week.
Thank you for bringing this to my attention!
- Baljinder Singh
…On Thu., Feb. 18, 2021, 1:36 p.m. Ludovic Rousseau, < ***@***.***> wrote:
Allo @balsingh1991 <https://github.com/balsingh1991>, any progress on the
use of SoftHSM with your patches?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2JAZ3YHOPF5UE6PHUPM73S7TC73ANCNFSM4OD6G2DA>
.
|
LudovicRousseau
requested changes
Aug 5, 2022
Owner
LudovicRousseau
left a comment
LudovicRousseau
left a comment
There was a problem hiding this comment.
It would be perfect if you could:
- rebase your patches above master
- split the patches with only one new feature per patch
| #define CKM_HKDF_DATA 0x0000402b | ||
| #define CKM_HKDF_KEY_GEN 0x0000402c | ||
| #define CKM_VENDOR_DEFINED 0x80000000UL | ||
| #define CKM_DES2_DUKPT_MAC (CKM_VENDOR_DEFINED + 0x612) |
Owner
There was a problem hiding this comment.
I can't include vendor specific mechanisms.
Are these mechanisms planned for a future version of PKCS#11 standard?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for CK_KEY_DERIVATION_STRING_DATA struct for use as mechanism parameters
Add support for DUKPT key derivation
Add support for ECIES encrypt/decrypt operations
Note: For DUKPT and ECIES operations, underlying cryto implementation must support it otherwise CKR_MECHANISM_INVALID error is encountered.