add options to disable and override ExplicitExpansion

[Angelinsky7]

Pr to implement #4325
from discussion from here : https://github.com/AutoMapper/AutoMapper/discussions/4323

The idea is to add 2 parameters to the ExplicitExpansion call :

Boolean explicitExpansion = true : instead of the hardcode true value we can control the value there
Boolean overrideExpansion = true: only used inside `ForAllMembers` like that we can decide if we override all the previous call to explicitExpansion or keep the value

and now we could do something like that

cfg.CreateMap<Source, Dto>()
        .ForMember(dto => dto.Desc, conf => conf.ExplicitExpansion())
        .ForMember(dto => dto.Name, conf => conf.MapFrom(src => src.Name))
        .ForMember(dto => dto.Code, conf => conf.ExplicitExpansion(false))
        .ForAllMembers(conf => conf.ExplicitExpansion(overrideExpansion: false));
});

and only the Code field will be implicitly expanded.

From my point of view, all tests passe (DI, Intergration, Unit) and some simple test were added to demonstrate.

I'm pretty sure this request misses something to be me merge as it is, but i hope that you will help.

[lbargaoanu]

First change the base branch to basic_include.

[lbargaoanu]

bool value = true

[lbargaoanu]

Does it work without the default?

[Angelinsky7]

yes it also work... i thought that if i added this to the IMemberConfigurationExpression it was good to add this here

[Angelinsky7]

done in the new pr

[lbargaoanu]

Remove overrideExpansion.

[Angelinsky7]

if i remove overrideExpansion the all thing doesn't work anymore.
because
.ForAllMembers(conf => conf.ExplicitExpansion())
will override all config and we won't be able to just disable one item (and let all the other be ExplicitExpansion=true)

[lbargaoanu]

That's the intended behaviour with ForAllMembers. The only usage for resetting explicit expansion is with mapping inheritance.

[Angelinsky7]

yes i know, but i have a lot of usecase where i would like to have 100 fields with ExplicitExpansion and only one Implicit.
Sadly ForAllMembers does not permit this. so i thought that i could add the possibility to configure ExplicitExpansion for inheritance and also for disabling only one field.
if i could chain calls after ForAllMembers i want have to do this. But because it was explicitly marked as void, i thought it was intended.

[lbargaoanu]

But you can simply add an if in ForAllMembers to skip setting ExplicitExpansion when you don't need it.

[Angelinsky7]

But you can simply add an if in ForAllMembers to skip setting ExpliitExpansion when you don't need it.

What ??!!! I didn't know that i could already do that... (or i didn't understand you correctly)

[lbargaoanu]

https://github.com/AutoMapper/AutoMapper/blob/104a192407858fe3a54a8a937ca95a34fd7c6959/src/UnitTests/AutoMapperSpecBase.cs#L61

[Angelinsky7]

i think i was not clear enough... what i was trying to solve is this kind of code :

CreateMap<TCheckSet, CheckSetFromCheckRequestDto>()
  .ForMember(dest => dest.Id, m => { m.MapFrom(src => src.Id); m.ExplicitExpansion(); })
  .ForMember(dest => dest.Equipment, m => { m.MapFrom(src => src.Equipment); m.ExplicitExpansion(); })
  .ForMember(dest => dest.PlannedDate, m => { m.MapFrom(src => src.PlannedDate); m.ExplicitExpansion(); })
  .ForMember(dest => dest.IsChecked, m => { m.MapFrom(src => src.IsChecked); m.ExplicitExpansion(); })
  .ForMember(dest => dest.ActualDate, m => { m.MapFrom(src => src.ActualDate); m.ExplicitExpansion(); })
  .ForMember(dest => dest.Status, m => { m.MapFrom(src => src.StatusId); m.ExplicitExpansion(); })
  .ForMember(dest => dest.Comments, m => { m.MapFrom(src => src.Comments); m.ExplicitExpansion(); })
  .ForMember(dest => dest.ActiveTypes, m => { m.MapFrom(src => src.ActiveTypes.Select(p => (TypeOfCheckTypeDto)p.Id)); })
  .ForMember(dest => dest.Jobs, m => { m.MapFrom(src => src.Jobs); m.ExplicitExpansion(); });
//.ForAllMembers(p => p.ExplicitExpansion());

CreateMap<TCheckSet, CheckSetDto>()
  .IncludeBase<TCheckSet, CheckSetFromCheckRequestDto>()
  .ForMember(dest => dest.CheckRequest, m => { m.MapFrom(src => src.CheckRequest); m.ExplicitExpansion(); });
  //.ForAllMembers(p => p.ExplicitExpansion());

and would like to write this kind instead

CreateMap<TCheckSet, CheckSetFromCheckRequestDto>()
   .ForMember(dest => dest.Id, m => m.MapFrom(src => src.Id))
   .ForMember(dest => dest.Equipment, m => m.MapFrom(src => src.Equipment))
   .ForMember(dest => dest.PlannedDate, m => m.MapFrom(src => src.PlannedDate))
   .ForMember(dest => dest.IsChecked, m => m.MapFrom(src => src.IsChecked))
   .ForMember(dest => dest.ActualDate, m => m.MapFrom(src => src.ActualDate))
   .ForMember(dest => dest.Status, m => m.MapFrom(src => src.StatusId))
   .ForMember(dest => dest.Comments, m => m.MapFrom(src => src.Comments))
   .ForMember(dest => dest.ActiveTypes, m => { m.MapFrom(src => src.ActiveTypes.Select(p => (TypeOfCheckTypeDto)p.Id)); m.ExplicitExpansion(false))
   .ForMember(dest => dest.Jobs, m => m.MapFrom(src => src.Jobs))
   .ForAllMembers(p => p.ExplicitExpansion());

CreateMap<TCheckSet, CheckSetDto>()
    .IncludeBase<TCheckSet, CheckSetFromCheckRequestDto>()
    .ForMember(dest => dest.CheckRequest, m => m.MapFrom(src => src.CheckRequest))
    .ForMember(dest => dest.Jobs, m => { m.MapFrom(src => src.Jobs);  m.ExplicitExpansion(false)})
    .ForAllMembers(p => p.ExplicitExpansion());

notice the subtle change for the ActiveTypes field and the use of ForAllMembers (and of course now the possibility to disable ExplicitExpansion for some fields)
but actually, if i'm doing this the settings of ActiveTypes is reset when i call ForAllMembers (witch the inheritance too, which could be more problematic)

[Angelinsky7]

i could even add , in this case i could rewrite the all thing like this

CreateMap<TCheckSet, CheckSetFromCheckRequestDto>()
   .ForMember(dest => dest.ActiveTypes, m => { m.MapFrom(src => src.ActiveTypes.Select(p => (TypeOfCheckTypeDto)p.Id)); m.ExplicitExpansion(false))
   .ForAllMembers(p => p.ExplicitExpansion());

CreateMap<TCheckSet, CheckSetDto>()
    .IncludeBase<TCheckSet, CheckSetFromCheckRequestDto>()
    .ForMember(dest => dest.CheckRequest, m => m.MapFrom(src => src.CheckRequest))
    .ForMember(dest => dest.Jobs, m => { m.MapFrom(src => src.Jobs);  m.ExplicitExpansion(false)})
    .ForAllMembers(p => p.ExplicitExpansion());

which feel really clean.. instead of all the config lines

[lbargaoanu]

You don't need ForAllMembers in the derived map. And all the explicit config goes against AM's purpose. I've already explained how the PR should look.

[lbargaoanu]

I'm afraid you chose the wrong test as model :) Start here instead.
You need to use Include and override in the derived map. Assert that both the base map and the derived map work as intended.
Also add a test for constructor mapping.

[Angelinsky7]

i can also add this, but i also had other requirements for this pr... this is why i chose this test. i understand now that it has more impact that i thought.

[Angelinsky7]

the new test have been created in the new pr

[lbargaoanu]

First change the base branch to basic_include.

[Angelinsky7]

First change the base branch to basic_include.

i think i mess up the base branch change, i would need to recreate the pr, but i would like to continue the discussion here first

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.