Skip to content

Null destination value type with mapper#3458

Merged
jbogard merged 25 commits into
masterfrom
dictionary_null_struct
Sep 16, 2020
Merged

Null destination value type with mapper#3458
jbogard merged 25 commits into
masterfrom
dictionary_null_struct

Conversation

@lbargaoanu

@lbargaoanu lbargaoanu commented Jul 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #3486. Fixes #3496.

@lbargaoanu lbargaoanu added the Bug label Jul 8, 2020
@lbargaoanu lbargaoanu added this to the v.next milestone Jul 8, 2020
@lbargaoanu lbargaoanu force-pushed the dictionary_null_struct branch 7 times, most recently from 408adb0 to 484826b Compare July 12, 2020 07:40
lbargaoanu
lbargaoanu commented Jul 12, 2020
View reviewed changes
Comment thread src/AutoMapper/ApiCompatBaseline.txt
@@ -1 +1,6 @@
Total Issues: 0
Compat issues with assembly AutoMapper:
InterfacesShouldHaveSameMembers : Interface member 'public void AutoMapper.IConfigurationProvider.Validate(AutoMapper.ValidationContext)' is present in the contract but not in the implementation.

@lbargaoanu lbargaoanu Jul 12, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why anyone would call this. I guess I made it public just because there is no clear separation between the public API and the internal API.

@jbogard jbogard Aug 25, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless, this will require a major version change if we break these contracts.

@lbargaoanu lbargaoanu Aug 25, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. Some things are public just because they might be useful from outside, they are not part of the API. While I'm not against releasing only major versions, it's not sending the right message, right? :) If people use this stuff, they'll break, but this seems better than not being able to do stuff at all.

@lbargaoanu lbargaoanu Aug 25, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should simply review what API Compat finds and make a judgement call. In this particular case, it seems simple enough.

@lbargaoanu lbargaoanu force-pushed the dictionary_null_struct branch 6 times, most recently from 6db55ad to 2835737 Compare July 14, 2020 11:39
@lbargaoanu lbargaoanu closed this Jul 15, 2020
@lbargaoanu lbargaoanu reopened this Jul 15, 2020
@lbargaoanu lbargaoanu force-pushed the dictionary_null_struct branch 10 times, most recently from 98cd6a5 to 03374e9 Compare July 19, 2020 05:32
@lbargaoanu lbargaoanu force-pushed the dictionary_null_struct branch 2 times, most recently from 2599fe2 to 5275638 Compare September 9, 2020 09:44
@lbargaoanu lbargaoanu force-pushed the dictionary_null_struct branch from 9a8242f to b8f6cd9 Compare September 9, 2020 11:28
@lbargaoanu lbargaoanu force-pushed the dictionary_null_struct branch 15 times, most recently from c1cc8ed to 1da0585 Compare September 13, 2020 06:24
@jbogard jbogard merged commit 6551613 into master Sep 16, 2020
@jbogard jbogard deleted the dictionary_null_struct branch September 16, 2020 18:18
@Kantuz001 Kantuz001 mentioned this pull request Oct 15, 2020
Closed
@github-actions

github-actions Bot commented Oct 18, 2020

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jbogard jbogard jbogard approved these changes

Assignees

@jbogard jbogard

Labels

Bug Internal refactoring

Projects

None yet

Milestone

10.1.0

Development

Successfully merging this pull request may close these issues.

IncludeMembers with double inheritance ProjectTo from collection to Nullable property breaks EF6 in version 10.0.0

2 participants

@lbargaoanu @jbogard