Add some changes by comments from @AnnaStoyano and @A-Ostrovnyy #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets make some small changes: You apply class logo for div tag. div is block element by default. kottans/frontend-2022-homeworks#85 (comment) Resolved Logo should be a link and leads user to the home page kottans/frontend-2022-homeworks#85 (comment) Resolved Avoid adding empty tags to commit kottans/frontend-2022-homeworks#85 (comment) Resolved When you have nested navigation better to use HTML lists for the first and other levels. kottans/frontend-2022-homeworks#85 (comment) Resolved Read article to find out how and when populating alt attribute kottans/frontend-2022-homeworks#85 (comment) Resolved Why you add id here? kottans/frontend-2022-homeworks#85 (comment) Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets make some small changes:
You apply class logo for div tag. div is block element by default.
kottans/frontend-2022-homeworks#85 (comment)
Resolved
Logo should be a link and leads user to the home page
kottans/frontend-2022-homeworks#85 (comment)
Resolved
Avoid adding empty tags to commit
kottans/frontend-2022-homeworks#85 (comment)
Resolved
When you have nested navigation better to use HTML lists for the first and other levels.
kottans/frontend-2022-homeworks#85 (comment)
Resolved
Read article to find out how and when populating alt attribute
kottans/frontend-2022-homeworks#85 (comment)
Resolved
Why you add id here?
kottans/frontend-2022-homeworks#85 (comment)
Resolved