[codex] unify cache capacity config#381
Conversation
|
Claude Code reviewed the stacked diff from #380 head to this branch. It found stale /props contract docs and an OpenAPI prefix_cache example mismatch, plus a note that legacy full_cache.enabled is RAM-only in disk-only prefill mode. Addressed those in 5a321eb (docs: align props cache contract). No runtime correctness findings were reported in that review. |
|
Follow-up pushed in 7568ed2 to make the unified cache model the primary user surface. Defaults now use --cache-ram 1GiB split as 256MiB prefix + 768MiB exact prefill, and --cache-disk 16GiB split as 4GiB prefix + 12GiB exact prefill when a cache dir is configured. The server also alternates cold-miss snapshot targets when both RAM pools are viable so exact repeated prompts and multi-turn prefix reuse can both populate without user tuning.\n\nValidation after this follow-up:\n- cmake build: test_server_unit + dflash_server\n- server/build/test_server_unit: 1978 assertions, 0 failures\n- py_compile for touched Python scripts\n- bash -n server/scripts/entrypoint.sh\n- OpenAPI YAML parse/cache example assertion\n- git diff --check\n- RAM exact-prefill proof: 1 commit, 2 hits, warm prefill rounded to 0.000s\n- Disk exact-prefill proof: RAM off, 1 disk save, 2 disk hits\n\nClaude Code reviewed this follow-up diff and reported no actionable correctness bugs. It flagged only a cosmetic /props example indentation issue, fixed before this commit. |
4b30337 to
93b1522
Compare
Summary
This is the org-visible stacked PR for the unified cache config model. It depends on #380.
Because the #380 head branch currently lives in the
easelfork and this account cannot push branches toLuce-Org/lucebox-hub, this PR is temporarily opened againstmain. That makes it visible to the team, but the GitHub compare includes #380 plus the unified-cache commit. Once #380 lands, this PR should be rebased/retargeted tomainso the visible diff collapses to the unified-cache work only.What changed
/props.Validation
cmake --build server/build --target test_server_unit dflash_server -j$(nproc)server/build/test_server_unit(1959 assertions, 0 failures)python3 -m py_compilefor changed Python scriptsbash -n server/scripts/entrypoint.shgit diff --checkDFLASH_SERVER_BIN=server/build/dflash_server python3 server/scripts/test_prefill_cache.pyDFLASH_SERVER_BIN=server/build/dflash_server python3 server/scripts/test_prefill_disk_cache.pyNotes
The cleaner branch layout would be base
Luce-Org:codex/prefill-cache-wiringand headLuce-Org:codex/unified-cache-config, but pushing those branches requires org write permission.