Skip to content

Conversation

@LDruelLucca
Copy link
Contributor

@LDruelLucca LDruelLucca commented Nov 26, 2025

Description

The goal of this PR is to switch all our components to OnPush.
The components affected that we migrated to input signals are:

  • PortalDirective
  • TextInputComponent
  • TimePickerComponent

ast visitor result on this comp :

-- TextInputComponent --

 [
    {
      link: 'https://github.com/LuccaSA/Lucca.Integrations/blob/dd8d18b46aec26b950869a77ada15beb5dc175bc/front/src/app/features/mapping-table/connector-config-mapping-table-create-rule-modal/connector-config-mapping-table-create-rule-modal.component.ts#L61',
      type: 'TypescriptUsage',
    },
    {
      link: 'https://github.com/LuccaSA/Lucca.Integrations/blob/dd8d18b46aec26b950869a77ada15beb5dc175bc/front/src/app/features/mapping-table/connector-config-mapping-table-create-rule-modal/connector-config-mapping-table-create-rule-modal.component.ts#L62',
      type: 'TypescriptUsage'
    },
    {
      link: 'https://github.com/LuccaSA/Figgo.Flex/blob/327525dec49aeb6c087d0b866a546acb86dba2b1/front/projects/timmi-office-spa/src/app/pages/settings/pages/work-locations/pages/pages/parking-floors/pages/parking-floor-page/parking-floor-page.component.ts#L120',
      type: 'TypescriptUsage'
    },
    {
      link: 'https://github.com/LuccaSA/Figgo.Flex/blob/327525dec49aeb6c087d0b866a546acb86dba2b1/front/projects/timmi-office-spa/src/app/pages/settings/pages/work-locations/pages/pages/work-location-floors/pages/floor-page/floor-page.component.ts#L148',
      type: 'TypescriptUsage'
    },
    {
      link: 'https://github.com/LuccaSA/Poplee.Recruitment/blob/10403f18338468030af9667a3aa3ddf9074c584e/front/libs/features/job-opportunities/src/lib/dialogs/setup-job-opportunity/stage-sortable-card/stage-sortable-card.component.ts#L65',
      type: 'TypescriptUsage'
    }
  ]

-- TimePickerComponent --

  [
    {
      link: 'https://github.com/LuccaSA/Timmi.Timesheet/blob/cd274274e299589743489f83398dab08521f1afb/front/projects/pwa/src/app/pages/submission/submission-large/components/time-interval-large-picker/time-interval-large-picker.component.ts#L110',
      type: 'TypescriptUsage'
    }
  ]

GuillaumeNury and others added 30 commits November 26, 2025 15:19
@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@jeremie-lucca
Copy link
Contributor

Imho we could update the non-breaking cases to LF21.0, but the timing seems very short to break all others input.
Maybe the breaking ones should be announced to the guild and pushed on LF22.0 in 6 months?

@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@JeSuisCharlie1
Copy link
Contributor

All uses related to the component are for element focusing, so it's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants