feat(phone-number): add autoPlaceholder input property #3330
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To discuss with Clément : set to |
jeremie-lucca
added
🎨 Design sync
Supamiu
reviewed
Jan 6, 2025
| @@ -67,6 +68,8 @@ export class PhoneNumberInputComponent implements ControlValueAccessor, Validato | |||
|
|
|||
| @Input() autocomplete?: 'off' | 'tel'; | |||
|
|
|||
| autoPlaceholder = input<boolean>(true); | |||
There was a problem hiding this comment.
I'm not a big fan of booleans with default value set to true, maybe we should use some kind of disable... input instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add input property
autoPlaceholderto phone-number-input component.False by default
If enabled, a placeholder will added to display an example, which will be a national phone number based on selected country code
Enregistrement.de.l.ecran.2024-12-24.a.15.06.53.mov