Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user-popover): remove useless alt and add alts on icons #3277

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Supamiu
Copy link
Contributor

@Supamiu Supamiu commented Dec 10, 2024

Description

fixes #3274


Optionally, technical or more in-depth description for reviewers.
Keep an empty line under your text, as well as the 5 lines that follow it.


@Supamiu Supamiu added 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.) 🔖🐛 FIX Bug / Visual fix (PR should target Master branch) labels Dec 10, 2024
@Supamiu Supamiu added this to the 18.3.4 milestone Dec 10, 2024
@Supamiu Supamiu requested review from a team as code owners December 10, 2024 10:48
@LuccaIntegration
Copy link

Copy link
Contributor

@martincadoux martincadoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste un petit retour sur le alt.

@LuccaIntegration
Copy link

@jeremie-lucca jeremie-lucca merged commit 3b96538 into master Dec 10, 2024
3 checks passed
@jeremie-lucca jeremie-lucca deleted the fix/user-popover-a11y branch December 10, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔖🐛 FIX Bug / Visual fix (PR should target Master branch) 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants