Improve override table key stuff #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasPickering
force-pushed
the
override-refactor
branch
from
398c3fb to
90486b7
Compare
Unify the associated types of RecipeFieldKind to reduce boilerplate for each user. This fixes all known bugs related to persistence with duplicate query params. Selected row, toggle state, and override state are all persisted correctly now.
Simplify the maps used to override headers/query params/form fields to use strings. In the case of query params, strings along aren't unique, so we also use key-specific indexes. This will make it much easier to define these overrides via the CLI. The index-only keys was only good for the TUI.
LucasPickering
force-pushed
the
override-refactor
branch
from
90486b7 to
09b9800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
Read the commit descriptions. It's good stuff!
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
QA
How did you test this?
Checklist
CONTRIBUTING.mdalready?CHANGELOG.md?