Customize config path with SLUMBER_CONFIG_PATH #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's an interesting commit message, isn't it. Apparently having the words "Basic" and "Bearer" in the changelog causes the CI to identify the release plan as containing "secrets", and therefore doesn't share it from the plan step to the execution steps. This error messages around this from Github are incredibly poor so I had to find the offending words with some binary search-type thing.
LucasPickering
force-pushed
the
config-env-var
branch
from
7ebc263
to
dbed26a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
Closes #370
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
SLUMBER_CONFIG_PATH. Mitigated by choosing a very specific var nameQA
How did you test this?
Checklist
CONTRIBUTING.mdalready?CHANGELOG.md?