Skip to content

Conversation

@yajo
Copy link
Contributor

@yajo yajo commented Feb 24, 2020

Doesn't make much sense to restrict this just to README, isn't it?

Doesn't make much sense to restrict this just to README, isn't it?
@yajo
Copy link
Contributor Author

yajo commented Feb 24, 2020

It seems this fails if there are several .md files. Maybe we need to add also require_serial: true?

@Lucas-C
Copy link
Owner

Lucas-C commented Feb 25, 2020

You can override this files value in .pre-commit-config.yaml !
cf. https://pre-commit.com/#plugins
No need to change the default value of this hook I think

@Lucas-C
Copy link
Owner

Lucas-C commented Feb 26, 2020

Considering my answer, unless you have anything to add @yajo, I will close this PR.

@yajo
Copy link
Contributor Author

yajo commented Feb 27, 2020

But why can't that be the default?

@Lucas-C
Copy link
Owner

Lucas-C commented Feb 27, 2020

Alright, all things considered, I'm merging this.

Thank you for your contribution !

@Lucas-C Lucas-C merged commit 7c1a484 into Lucas-C:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants