Skip to content

docs: update sample snippet for nestjs v9 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2023
Merged

docs: update sample snippet for nestjs v9 #6

merged 1 commit into from
Feb 21, 2023

Conversation

micalevisk
Copy link
Contributor

@micalevisk micalevisk commented Feb 21, 2023

Middlewares and non-global guards aren't supposed to be listed in the providers array. Although that code works fine, it's does nothing (ie., the middleware and the guard aren't applied)

Is there any reason why did you have them in that code snippet? 🤔 I might be missing something

@LucaScorpion
Copy link
Owner

You're absolutely right, reason for this is mostly that it's a bit of a contrived example 😅 But I agree that might throw people off, and without them the example is still as clear. Thanks for the PR! 🙌

@LucaScorpion LucaScorpion merged commit 181de43 into LucaScorpion:main Feb 21, 2023
@micalevisk micalevisk deleted the patch-1 branch February 21, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants