mark 1.21.6 as supported and adjust dependency resolution #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested LuaLink on 1.21.6 and as expected, it seems to work perfectly fine. Bumped versions, including Paper API dependency which I will talk about in the next paragraph.
With PaperMC/Paper#12689 being part of Paper now, I had to adjust how we download internal, and user-specified dependencies in the runtime. Paper API version bump was needed in order to use API introduced by mentioned PR. Logic should gracefully fallback to existing methods when needed.
Plugin still works as it used to and no breaking changes were introduced. I tested on 1.20, 1.21.4 and 1.21.6.
LuaCommand changes had to be made in order to make the plugin compilable, but they also seem to be non-breaking and backwards compatible.
Ready for review. I added two commits so you may want to squash before merging.