fix: type narrowing bugs with literal fields #3098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to properly link multiple issues, I believe the PR description needs to be: i.e. each issue needs to be prefixed with Currently only #3089 is linked: |
Fixes LuaLS#3089 Fixes LuaLS#2952 Fixes LuaLS#3056
lewis6991
force-pushed
the
fix/narrow
branch
from
d185dfd to
1501f15
Compare
lewis6991
commented
Feb 27, 2025
| @@ -268,6 +268,11 @@ local function getNodeTypesWithLiteralField(uri, source, fieldName, literal) | |||
| return | |||
| end | |||
|
|
|||
| -- Literal must has a value | |||
| if literal[1] == nil then | |||
| return | |||
There was a problem hiding this comment.
I think this is only reachable when literal.type = 'nil'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3089
Fixes #2952
Fixes #3056