PHPOffice#634 : Enable PHPStan

.github/workflows/php.yml

@@ -44,20 +44,23 @@ jobs:
   phpstan:
     name: PHP Static Analysis
     runs-on: ubuntu-latest
-    continue-on-error: true
+    strategy:
+      fail-fast: false
+      matrix:
+        php: ['7.1', '7.2', '7.3', '7.4', '8.0'] #, '8.1'
     steps:
         -   name: Setup PHP
             uses: shivammathur/setup-php@v2
             with:
-                php-version: '7.4'
+                php-version: ${{ matrix.php }}
                 extensions: gd, xml, zip
         -   uses: actions/checkout@v2
 
         -   name: Composer Install
             run: composer install --ansi --prefer-dist --no-interaction --no-progress
 
-        #-   name: Run phpstan
-        #    run: ./vendor/bin/phpstan analyse -c phpstan.neon.dist
+        -   name: Run phpstan
+            run: ./vendor/bin/phpstan analyse -c phpstan.neon.dist
 
   phpunit:
     name: PHPUnit

composer.json

@@ -27,7 +27,8 @@
     "require-dev": {
         "phpunit/phpunit": ">=7.0",
         "phpdocumentor/phpdocumentor":"^2.0|^3.0",
-        "phpmd/phpmd": "2.*"
+        "phpmd/phpmd": "2.*",
+        "phpstan/phpstan": "^0.12.88"
     },
     "suggest": {
         "ext-gd": "Required to add images"

phpstan.neon.dist

@@ -0,0 +1,29 @@
+parameters:
+  level: 6
+  bootstrapFiles:
+    - tests/bootstrap.php
+  paths:
+    - src
+    - tests
+  reportUnmatchedIgnoredErrors: false
+  ignoreErrors:
+    ## Relative to PHPExcel
+    - '#^Call to static method createWriter\(\) on an unknown class PHPExcel_IOFactory\.#'
+    - '#^Call to static method stringFromColumnIndex\(\) on an unknown class PHPExcel_Cell\.#'
+    ## Relative to Common
+    - '#^Parameter \#1 \$pValue of static method PhpOffice\\Common\\Drawing\:\:angleToDegrees\(\) expects int, string given\.#'
+    - '#^Parameter \#1 \$pValue of static method PhpOffice\\Common\\Drawing\:\:centimetersToPixels\(\) expects int, string given\.#'
+    - '#^Parameter \#1 \$pValue of static method PhpOffice\\Common\\Drawing\:\:degreesToAngle\(\) expects int, float given\.#'
+    - '#^Parameter \#1 \$pValue of static method PhpOffice\\Common\\Drawing\:\:emuToPixels\(\) expects int, float given\.#'
+    - '#^Parameter \#1 \$pValue of static method PhpOffice\\Common\\Drawing\:\:emuToPixels\(\) expects int, string given\.#'
+    - '#^Parameter \#1 \$pValue of static method PhpOffice\\Common\\Drawing\:\:pixelsToCentimeters\(\) expects int, float given\.#'
+    - '#^Parameter \#1 \$pValue of static method PhpOffice\\Common\\Drawing\:\:pixelsToEmu\(\) expects int, float given\.#'
+    ## PHP 8.0 & GdImage
+    - '#^Parameter \#1 \$value of method PhpOffice\\PhpPresentation\\Shape\\Drawing\\Gd::setImageResource\(\) expects resource\|null, GdImage\|false given\.#'
+    - '#^Parameter \#1 \$image of function imagesx expects GdImage, resource given\.#'
+    - '#^Parameter \#1 \$image of function imagesy expects GdImage, resource given\.#'
+    - '#^Parameter \#1 \$image of function imagealphablending expects GdImage, resource given\.#'
+    - '#^Parameter \#1 \$image of function imagesavealpha expects GdImage, resource given\.#'
+
+  ## Remove after remove ArrayObject
+  treatPhpDocTypesAsCertain: false