Add square/wire #84
Draft
Add square/wire #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @sijanr , will have a look and expand on it, but not very soon because I'm moving home 👍 |
LouisCAD
requested changes
Oct 30, 2020
kotlin-jvm/build.gradle.kts
Outdated
Comment on lines
15
to
-14
| repositories { | ||
| mavenLocal() | ||
| mavenCentral() |
There was a problem hiding this comment.
Why did you remove mavenCentral()?
Comment on lines
+29
to
+33
| wire { | ||
| kotlin { | ||
|
|
||
| } | ||
| } |
| maven(url = "https://dl.bintray.com/kotlin/kotlin-eap/") | ||
| } | ||
|
|
||
|
|
| implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:_") | ||
| implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:_") | ||
| implementation("org.kodein.di:kodein-di:_") | ||
| implementation ("com.squareup.wire:wire-runtime:3.4.0") |
There was a problem hiding this comment.
Did you read the contributing guide? If so, please read it again, otherwise, please read it, there's some important considerations regarding adding dependencies.
Comment on lines
-94
to
+104
| tasks.register("run", JavaExec::class.java) { | ||
| this.main = "playground._mainKt" | ||
| } | ||
|
|
Comment on lines
-94
to
-96
| tasks.register("run", JavaExec::class.java) { | ||
| this.main = "playground._mainKt" | ||
| } |
kotlin-jvm/settings.gradle.kts
Outdated
Comment on lines
-4
to
+11
| repositories { mavenLocal() ; gradlePluginPortal() } | ||
| repositories { mavenLocal() } |
There was a problem hiding this comment.
Why did you remove the gradlePluginPortal() repo?
| id("com.gradle.enterprise") version "3.4.1" | ||
| } | ||
|
|
||
|
|
| } | ||
| } | ||
|
|
||
|
|
Comment on lines
+3
to
+4
| fun main() { | ||
| } No newline at end of file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8