Remove id attributes when disableShadowDOM="true"

[tomasdev]

Using multiple players end up creating DOM with repeated IDs: "#animation" and "#animation-container" -- these could be replaced with classes instead.

I am not sure of the implications when using Shadow DOM.

[samuelOsborne]

hi @tomasdev whats your use case for not having shadowDOM enabled?

[tomasdev]

Colorizing the paths using CSS (single color Lottie files) -- icons animations.

In addition, not using Shadow DOM makes the controls not show up when controls="true"

[tomasdev]

I think (untested) we could colorize the paths if the SVG was slotted when using Shadow DOM.

[samuelOsborne]

the problem with repeating ids shouldnt be an issue though no? As its inside the shadow dom they dont conflict

[tomasdev]

This is when shadow dom is off, as title suggests

…

On Thu, Jan 18, 2024 at 6:58 AM SamuelOsborne ***@***.***> wrote: the problem with repeating ids shouldnt be an issue though no? As its inside the shadow dom they dont conflict — Reply to this email directly, view it on GitHub <#236 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACY4AIEB5KUIK33FIUQLELYPEE47AVCNFSM6AAAAABB6Y2Y66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYGM2DEOJYGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Tomás Roggero https://tomasroggero.com