Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 memory access out of range on resize #76

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

theashraf
Copy link
Member

Problem:
The resize method in LottieRenderer creates a new Picture every time called causing memory out of access as it returns a new Picture instance, not the same Picture instance associated with the current Animation created on load.

Fix:

  • Maintain a thorvg_picture property in the LottieRenderer, and use the same thorvg_picture created on load when resizing.
  • Resize the buffer instead of allocating a new one in memory to maintain it's raw pointer address in memory during the lifetime of the LottieRenderer

Copy link

changeset-bot bot commented Feb 4, 2024

⚠️ No Changeset found

Latest commit: 78ccf4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf requested review from samuelOsborne and afsalz and removed request for samuelOsborne February 4, 2024 15:08
Copy link
Collaborator

@afsalz afsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay 🚀 android is working fine now.

@theashraf theashraf merged commit 443ae46 into main Feb 5, 2024
1 check passed
This was referenced Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants