Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🤖 update emscripten bindings #40

Merged
merged 6 commits into from
Jan 16, 2024
Merged

fix: 🤖 update emscripten bindings #40

merged 6 commits into from
Jan 16, 2024

Conversation

theashraf
Copy link
Member

@theashraf theashraf commented Jan 14, 2024 •
edited
Loading

  • adds emscripten bindings for the native DotLottiePlayer
  • fix an issue where the std::time::SystemTime not working properly in emscripten target (rely on instant crate instead)
  • add nodejs example

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7ebc4f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf marked this pull request as ready for review January 15, 2024 01:27
@theashraf theashraf force-pushed the chore/update-emscripten-bindings branch from c224d14 to 7024163 Compare January 15, 2024 08:01
@theashraf theashraf force-pushed the chore/update-emscripten-bindings branch from f424146 to 7ebc4f6 Compare January 16, 2024 02:26
@theashraf theashraf changed the title chore: 🤖 update emscripten bindings fix: 🤖 update emscripten bindings Jan 16, 2024
afsalz
afsalz approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@afsalz afsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@theashraf theashraf merged commit 4129c94 into main Jan 16, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Merged
@theashraf theashraf deleted the chore/update-emscripten-bindings branch June 7, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afsalz afsalz afsalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theashraf @afsalz