feat: add jerryscript bindings and experimental eval action to state machine engine #395
+502
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
theashraf
force-pushed
the
feat/eval-action
branch
from
4de3f7a to
9615b85
Compare
This merge resolves conflicts between the feat/eval-action branch and main: - build.rs: Merged jerryscript bindings generation with main's simplified tvg feature flags and new TVG_STATIC/WIN32_LEAN_AND_MEAN defines - Cargo.toml: Updated to use simplified tvg feature (removed tvg-v0/tvg-v1) - inputs/mod.rs: Merged InputTrait trait addition from main with existing code, ensuring all trait methods are properly implemented including get_event() - state_machine_engine/mod.rs: Kept main's refactored input system (public inputs field, removed event_input HashMap) and merged with feat/eval-action's jerryscript support (js_context field, get_js_context() method) - actions/mod.rs: Kept Eval action implementation from feat/eval-action - transitions/guard.rs: Added InputTrait import for trait method access - demo-state-machine/Cargo.toml: Updated to use explicit feature list All changes maintain functionality of both the eval action and the build system.
theashraf
force-pushed
the
feat/eval-action
branch
from
9615b85 to
d272f64
Compare
📊 Benchmark Resultsdotlottie-rs
How to interpret these results
Criterion uses statistical analysis to account for noise and provide reliable comparisons. |
Fixed 6 clippy errors blocking CI: 1. Module inception: Renamed inner jerryscript module to ffi 2. Dead code: Removed unused handle() method from Value impl 3. Enum variant names: Renamed Utf8Error to Utf8 (4 occurrences) 4. Redundant pattern matching: Replaced if let Some(_) with .is_some() (3 instances) All changes are style/lint fixes with no functional impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.