Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made thorvg an optional dependency #248

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

dragostis
Copy link
Contributor

This makes building the crate easier without having Conan installed and it should enable docs being generated on docs.rs.

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 9550c50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dragostis dragostis force-pushed the feat/optional-thorvg branch 4 times, most recently from 4048c66 to 0912481 Compare October 17, 2024 12:00
This makes building the crate easier without having Conan installed
and it should enable docs being generated on docs.rs.

As a bonus, this also removes all the ThorVG FFI from the public
API.
Copy link
Member

@theashraf theashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @dragostis !! 🚀

@theashraf theashraf merged commit aa4a152 into LottieFiles:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants