fix: corrected thorvg canvas sync

[tinyjin]

Ensure thorvg_canvas_sync is called in correct way, before buffer changes.

---

Essentially thorvg_canvas_sync() shouldn't interrupt following code lines, regardless of it's return value.

See the good example:
https://github.com/thorvg/thorvg/blob/main/src/bindings/wasm/tvgWasmLottieAnimation.cpp#L287

Corrected the function in fire-and-forget pattern.

Previously, lotte_renderer handle the InsufficientCondition(status == Status::Synced) as an error and block next steps in resize() function. (fell in that set_target, compute_layout never happend)

self.buffer
  .resize((self.width * self.height * 4) as usize, 0);
        
self.thorvg_canvas.sync()?;

// When canvas status is already `Synced`
// After this point, every lines blocked
self.thorvg_canvas
    .set_target(
        &mut self.buffer,
        self.width,
        self.width,
        self.height,
        get_color_space_for_target(),
    )
    .map_err(LottieRendererError::ThorvgError)?;

// ...

Ok(())

We shouldn't handle the status == Synced case as an error. Corrected the sync() without using the Rust try operator (?)

---

[Before]

CleanShot.2024-08-29.at.23.13.24.mp4

[After]

CleanShot.2024-08-29.at.23.08.37.mp4

[changeset-bot]

⚠️ No Changeset found

Latest commit: c4b917d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[hermet]

It might need to double-check whether it works correctly if removing viewport call.

[theashraf]

Awesome work @tinyjin, it works perfectly 🚀

[tinyjin]

Thanks @theashraf, ThorVG team also on reviewing some internal thing, changed to DRAFT. �I'll soon let u know when it's ready.

[tinyjin]

@theashraf Updated logic more properly, please check again :)

Note that result of thorvg_canvas_sync() shouldn't be captured in animating logic.