Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 create_default_config ffi #129

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

theashraf
Copy link
Member

dotLottie web/android/ios implements the default config value independently, this PR provides a ffi function that would return the expected default player config across platforms for consistently

Changes:

  • Expose create_default_config via uniffi .udl & emscripten bindings
  • Update web example for testing purpose

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: f4d6ff6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf added the enhancement New feature or request label Apr 8, 2024
@theashraf theashraf self-assigned this Apr 8, 2024
@theashraf theashraf merged commit a2d65ca into main Apr 8, 2024
1 check failed
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
@github-actions github-actions bot mentioned this pull request May 2, 2024
@github-actions github-actions bot mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants