(android): implement persistent CPU performance mode and lifecycle stability guards - #120
Open
acedmicabhishek wants to merge 4 commits into
Open
(android): implement persistent CPU performance mode and lifecycle stability guards#120acedmicabhishek wants to merge 4 commits into
acedmicabhishek wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 2d12427 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had issue with .lottie
Android's
SurfaceFlingerhas a hardcoded rule to destroy the GL context for out-of-focus screens. The existing Android-lottie implementation struggles to successfully re-hook the rendering context to newly active windows, which leads to.lottiehot-reload issues and dropped render hooks.To bypass this OS-level limitation and drastically improve remount efficiency, this update introduces a native caching system and exposes two new properties for granular performance tuning.
Improvements
performanceMode): Introduced a globalplayerCachethat allows theDotLottiePlayerinstance to survive view detachment. This entirely eliminates the expensive JSON/binary parsing overhead when remounting the same animation (e.g., when navigating between tabs in a Bottom Navigation Bar).cacheId): Added support for unique cache identifiers to accurately store and retrieve specific player instances.Window composer not foundcrashes. The render-loop is now immediately paused duringonDetachedFromWindow, and explicit disposal cleanup has been added to the Compose wrapper.React Native Integration
These changes were designed in tandem with updates to the
@lottiefiles/dotlottie-react-nativebridge. By exposingperformanceModeandcacheIdthrough the bridge, React Native applications can now achieve premium UI responsiveness on Android by caching heavy animation models directly in native memory.