Handle broken pipe errors during streaming #572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have the same problem as reported in #568 (while using /api/extra/generate/stream). The easiest way to reproduce this behavior is by starting a streaming connection and then simply dropping it, for example
Starting a new connection will then cause a crash.
One way to fix this is by handling BrokenPipeError. There is already a code for handling ConnectionAbortedError and I have tried to trigger it (without explicitly closing connection on a client) but failed. It's not entirely clear to me what is the difference between the two, however handling BrokenPipeError in the same way as ConnectionAbortedError does fix the problem.