fix unintended sd model quantization #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent ggml update added another quant type, GGML_TYPE_MXFP4, which got the same value as SD_TYPE_COUNT. That made the embedded sd.cpp quantize to GGML_TYPE_MXFP4 by default. Photomaker in particular ends up crashing due to "Missing CPY op for types: f32 mxfp4".
|
Ah thank you for spotting this! That makes a lot of sense |
LostRuins
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent ggml update added another quant type, GGML_TYPE_MXFP4, which got the same value as SD_TYPE_COUNT. That made the embedded sd.cpp quantize to GGML_TYPE_MXFP4 by default.
Photomaker in particular ends up crashing due to "Missing CPY op for types: f32 mxfp4".
Related: leejet/stable-diffusion.cpp#760