fix(jsdom): don't go into an infinite recusion when calling atob

LorenzoBloedow · Dec 4, 2023 · da7949d · da7949d
1 parent 39c952a
commit da7949d
Show file tree

Hide file tree

Showing 5 changed files with 111 additions and 42 deletions.
diff --git a/packages/vitest/package.json b/packages/vitest/package.json
@@ -180,7 +180,7 @@
     "flatted": "^3.2.9",
     "get-tsconfig": "^4.7.2",
     "happy-dom": "^12.10.3",
-    "jsdom": "^22.1.0",
+    "jsdom": "^23.0.1",
     "log-update": "^6.0.0",
     "micromatch": "^4.0.5",
     "p-limit": "^5.0.0",

diff --git a/packages/vitest/src/integrations/env/jsdom-keys.ts b/packages/vitest/src/integrations/env/jsdom-keys.ts
@@ -188,9 +188,9 @@ const LIVING_KEYS = [
 const OTHER_KEYS = [
   'addEventListener',
   'alert',
-  'atob',
+  // 'atob',
   'blur',
-  'btoa',
+  // 'btoa',
   'cancelAnimationFrame',
   /* 'clearInterval', */
   /* 'clearTimeout', */

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/core/test/environments/happy-dom.spec.ts b/test/core/test/environments/happy-dom.spec.ts
@@ -15,3 +15,8 @@ test('global CSS is injected correctly', () => {
   expect(CSS.escape).toBeDefined()
   expect(CSS.supports).toBeDefined()
 })
+
+test('atob and btoa are available', () => {
+  expect(atob('aGVsbG8gd29ybGQ=')).toBe('hello world')
+  expect(btoa('hello world')).toBe('aGVsbG8gd29ybGQ=')
+})
diff --git a/test/core/test/environments/jsdom.spec.ts b/test/core/test/environments/jsdom.spec.ts
@@ -28,6 +28,11 @@ test.runIf(nodeMajor >= 18)('fetch, Request, Response, and BroadcastChannel are
   expect(BroadcastChannel).toBeDefined()
 })
 
+test('atob and btoa are available', () => {
+  expect(atob('aGVsbG8gd29ybGQ=')).toBe('hello world')
+  expect(btoa('hello world')).toBe('aGVsbG8gd29ybGQ=')
+})
+
 test('toContain correctly handles DOM nodes', () => {
   const wrapper = document.createElement('div')
   const child = document.createElement('div')