Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No transactions v0 spikesorting pipeline #1187

Merged
merged 3 commits into from
Nov 14, 2024
Merged

No transactions v0 spikesorting pipeline #1187

merged 3 commits into from
Nov 14, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Nov 14, 2024 •
edited
Loading

Description

Resolves #1186

  • Turns of populate transactions for:
    • spikesorting.v0.Waveforms
    • spikesorting.v0.QualityMetrics

Checklist:

  • N This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • N This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review November 14, 2024 17:44
@samuelbray32 samuelbray32 marked this pull request as draft November 14, 2024 18:41
@samuelbray32
Copy link
Collaborator Author

Noticed that locks on IntervalList will also cause issues on some table declarations. Adding no transaction to v0.SpikeSortingRecording for this reason

@samuelbray32 samuelbray32 changed the title No transactions v0 Waveforms or Metrics No transactions v0 spikesorting pipeline Nov 14, 2024
@samuelbray32 samuelbray32 marked this pull request as ready for review November 14, 2024 18:57
@samuelbray32 samuelbray32 merged commit 4231e51 into master Nov 14, 2024
17 checks passed
@samuelbray32 samuelbray32 deleted the spike_v0_transaction branch November 14, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid transactions in spikesorting v0 pipeline
2 participants
@samuelbray32 @CBroz1