Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #1181

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix failing tests #1181

merged 1 commit into from
Nov 8, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Nov 8, 2024

Description

This PR updates tests based on #1048

  • changing inheritance order requires initialization where previously not neede
  • adding another arg to merge_fetch prevented calling attrs as positional arguments

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • N/a. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review November 8, 2024 19:49
@edeno edeno merged commit fa1114e into LorenFrankLab:master Nov 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants