Skip to content

feat: add exponential backoff and forceful killing to free occupied p… #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shekhardtu wants to merge 1 commit into from
Closed

feat: add exponential backoff and forceful killing to free occupied p… #5

shekhardtu wants to merge 1 commit into from

Conversation

@shekhardtu
Copy link
Contributor

@shekhardtu shekhardtu commented Jul 8, 2025 •
edited
Loading

…orts

  • Implement exponential backoff with 5 retry attempts
  • Progressive force: SIGTERM → SIGKILL → system-level force kill
  • Enhanced process detection for TCP/UDP on Unix systems
  • Kill entire process tree on Windows
  • Re-check for new processes between attempts
  • Suggest elevated privileges when needed
  • Better debug logging throughout the process

Pull Request

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test improvements
  • CI/CD improvements
  • Dependencies update

Related Issues

Fixes #

Changes Made

Core Changes

Additional Changes

Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • All existing tests pass

Test Details

# Commands used for testing
npm test
npm run lint
npm run typecheck

Configuration Changes

  • No configuration changes
  • oats.config.json schema updated
  • CLI options added/modified
  • Environment variables added/modified

Config Example

{
  "newOption": "example-value"
}

Breaking Changes

  • No breaking changes
  • Minor breaking changes (list below)
  • Major breaking changes (list below)

Migration Guide

Performance Impact

  • No performance impact
  • Performance improvement
  • Minor performance impact (acceptable)
  • Significant performance impact (justify below)

Performance Details

Documentation

  • README.md updated
  • CHANGELOG.md updated
  • Code comments added/updated
  • Type definitions updated
  • Examples updated
  • No documentation changes needed

Dependencies

  • No new dependencies
  • New production dependencies added (justify below)
  • New development dependencies added
  • Dependencies updated
  • Dependencies removed

Dependency Justification

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots

Additional Notes

Reviewer Notes

Please review:

  • Code quality and style
  • Test coverage
  • Documentation accuracy
  • Performance impact
  • Security implications

Note for Maintainers: Please ensure this PR is properly labeled and assigned to the appropriate milestone.

@github-actions
feat: add exponential backoff and forceful killing to free occupied p…
5be132b 
…orts

- Implement exponential backoff with 5 retry attempts
- Progressive force: SIGTERM → SIGKILL → system-level force kill
- Enhanced process detection for TCP/UDP on Unix systems
- Kill entire process tree on Windows
- Re-check for new processes between attempts
- Suggest elevated privileges when needed
- Better debug logging throughout the process
@claude
Copy link

claude bot commented Jul 8, 2025 •
edited
Loading

Claude encountered an error —— View job

I'll analyze this and get back to you.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 8, 2025
View reviewed changes
src/utils/port-manager.ts
let delay = initialDelay;
let portFreed = false;

while (attempt < maxAttempts && !portFreed) {

Check warning

Code scanning / CodeQL

Useless conditional Warning

This negation always evaluates to true.
@shekhardtu shekhardtu closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shekhardtu