Ensure completion closure is always called in acknowledgeAlert()#64
Merged
marionbarker merged 2 commits intoLoopKit:mainfrom Dec 14, 2025
Merged
Conversation
marionbarker
approved these changes
Dec 14, 2025
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approved from code review.
Did a test build with both OmniBLE PR 158 and OmniKit PR 64 that was successful.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acknowledgeAlert() has some cases where its completion closure would not be called. Besides being bad form, this caused some difficulties which resulted in some controllers like iAPS & Trio having to add a hack that had to look into what should be private PM state.