Skip to content

Conversation

@ps2
Copy link
Collaborator

@ps2 ps2 commented Oct 5, 2018

  • Update IOB and COB immediately after carb/bolus send
  • Adjust complication push budget to spend evenly before midnight
  • Adjustments for Series 4, including rounded action buttons, correct text margin insets, and using system scroll haptics
  • Improve efficiency of the chart redraw

ps2 added 2 commits October 5, 2018 00:14
- Update IOB and COB immediately after carb/bolus send
- Adjust complication push budget to spend evenly before midnight
- Adjustments for Series 4, including rounded action buttons, correct text margin insets, and using system scroll haptics
- Improve efficiency of the chart redraw
].joined(separator: "\n")
}

fileprivate var complicationUserInfoTransferInterval: TimeInterval {
Copy link
Contributor

@mpangburn mpangburn Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I've been digging into this over the last week or two, I've found that midnight isn't the right estimate for the budget reset time—@elnjensen and I have been recording 5AM budget resets, but I don't think our two experiences are sufficient evidence to make a general conclusion.
I'm continuing to look into this, but we'd benefit from more logging here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have been recording additional resets at 5am (so a midnight and a 5am reset?) or no midnight reset, and just the 5am one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 5:02 AM every day, but not midnight, at least for the two of us who have been tracking it - see #816 . What we've observed is a daily reset at 5 AM, and then an additional reset (which doesn't change the daily schedule) whenever the Watch is fully charged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. The midnight target isn't an estimate of when the counter will reset, but an estimate of when the user will be asleep. Still open to better algorithms for divvying this resource up, though.

@ps2 ps2 merged commit 34c390a into dev Oct 6, 2018
elnjensen added a commit to elnjensen/Loop that referenced this pull request Oct 9, 2018
@ps2 ps2 deleted the watch-feature-updates branch January 8, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants