From DM61's work on IRC, fixes a case where RC velocity can have an a… #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No way to have all IRC merged? Atm i saw there are a lot of loop versions on many repos from different users with different features. I believe you can create alpha releases with unsafe mod just to test them. Then when they are ok you will put them in dev and then in master. |
|
Imho of course :-) |
|
IRC is likely going to end up in Loop, but there are some structural changes to be made first, to better handle recomputation when needed. |
…rtificially large magnitude from short glucose change intervals.
|
|
Kdisimone
pushed a commit
to Kdisimone/Loop
that referenced
this pull request
Aug 16, 2018
LoopKit#778) * From DM61's work on IRC, fixes a case where RC velocity can have an artificially large magnitude from short glucose change intervals. * Typo
dm61
added a commit
to dm61/Loop
that referenced
this pull request
Aug 23, 2018
Kdisimone
added a commit
to Kdisimone/Loop
that referenced
this pull request
Aug 24, 2018
* integral retrospective correction Adds integral action to retrospective correction * integral retrospective correction, safer velocity calculation * integral retrospective correct, reset if glucose data missing * update integral RC only after glucose update fix for multiple calls to updateRetrospectiveGlucoseEffect in Loop 1.5.4 * display retrospective correction effect * integral RC indicator * - * Retrospective correction indicator * Retrospective correction indicator * Reinitialize integral RC states after Loop restart * RC disabled vs inactive messages * update IRC to LoopKit v2 * more robust glucose update check * resolve conflicts with LoopKit#778
lgruen
pushed a commit
to lgruen/Loop
that referenced
this pull request
Aug 27, 2018
* integral retrospective correction Adds integral action to retrospective correction * integral retrospective correction, safer velocity calculation * integral retrospective correct, reset if glucose data missing * update integral RC only after glucose update fix for multiple calls to updateRetrospectiveGlucoseEffect in Loop 1.5.4 * display retrospective correction effect * integral RC indicator * - * Retrospective correction indicator * Retrospective correction indicator * Reinitialize integral RC states after Loop restart * RC disabled vs inactive messages * update IRC to LoopKit v2 * more robust glucose update check * resolve conflicts with LoopKit#778
Kdisimone
added a commit
to Kdisimone/Loop
that referenced
this pull request
Sep 19, 2018
* integral retrospective correction Adds integral action to retrospective correction * integral retrospective correction, safer velocity calculation * integral retrospective correct, reset if glucose data missing * update integral RC only after glucose update fix for multiple calls to updateRetrospectiveGlucoseEffect in Loop 1.5.4 * display retrospective correction effect * integral RC indicator * - * Retrospective correction indicator * Retrospective correction indicator * Reinitialize integral RC states after Loop restart * RC disabled vs inactive messages * update IRC to LoopKit v2 * more robust glucose update check * resolve conflicts with LoopKit#778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rtificially large magnitude from short glucose change intervals.