select the pickerValue based on 75% of recommendedBolus #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps2
reviewed
Jul 19, 2018
| @@ -93,8 +93,7 @@ final class BolusInterfaceController: WKInterfaceController, IdentifiableClass { | |||
| maxBolusValue = recommendedBolus | |||
| } | |||
|
|
|||
| let recommendedPickerValue = pickerValueFromBolusValue(recommendedBolus) | |||
| pickerValue = Int(Double(recommendedPickerValue) * 0.75) | |||
| pickerValue = pickerValueFromBolusValue(recommendedBolus * 0.75) | |||
There was a problem hiding this comment.
I think this looks good. Tiny nitpick; there's an extra space after recommendedBolus
previously was using 75% of the pickerValue also remove the extra casting
jasoncalabrese
force-pushed
the
watch-prefil
branch
from
7cbf378 to
e670821
Compare
|
good catch, cleaned it up |
|
Editor -> Show Invisibles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously was using 75% of the pickerValue
also remove the extra casting