Merged
Conversation
Added logic attempting to open G5 app first, G4 app (Share 2) if G5 app is not installed
Collaborator
|
Congrats on your first Swift code! I'm ready to merge when Travis finishes. |
ps2
added a commit
that referenced
this pull request
Aug 23, 2019
* Add DashKit * Remove output from copy-files phase to force update each time * Sign plugins * Remove quotes to handle empty list * Handle spaces, deref symlink, and re-enable bitcode * Comment out testing vars * Fix version for archive builds * Move plugin's frameworks to main app frameworks directory * Fix search for plugin's frameworks * Set marketing version via config * Update copy frameworks script to dereference framework symlinks * Use copy-frameworks script for extensions and learn app * Bumping build version * Add missing script * Back out development team id changes * Scripts fixes from review * Fix capitalization * Small tweaks
dthornley
added a commit
to dthornley/Loop
that referenced
this pull request
Aug 25, 2019
* upstream/dev: Update carthage revs Revert temp basal enact ui in status bar Add translations for New Carb Entry intent, fix plugins for app extension Fix chartHashValue for GlucoseChartValueHashable (LoopKit#1073) Update copy-frameworks to test presence correctly, and follow symlinks for release builds (LoopKit#1076) Resolve conflict lines Plugins (LoopKit#22) Use new ISF and Correction Range interfaces with guardrails (LoopKit#21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20