Skip to content

Fix date picker appearance for carb entry in iOS 14 #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Fix date picker appearance for carb entry in iOS 14 #1393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5f7a9f
Fix carb date picker
novalegra Sep 27, 2020
60b44ad
Fix CI build
novalegra Sep 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Loop/View Controllers/CarbEntryViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,11 @@ final class CarbEntryViewController: ChartsTableViewController, IdentifiableClas
cell.titleLabel.text = NSLocalizedString("Date", comment: "Title of the carb entry date picker cell")
cell.datePicker.isEnabled = isSampleEditable
cell.datePicker.datePickerMode = .dateAndTime
#if swift(>=5.2)
if #available(iOS 14.0, *) {
cell.datePicker.preferredDatePickerStyle = .wheels
}
#endif
cell.datePicker.maximumDate = Date(timeIntervalSinceNow: maximumDateFutureInterval)
cell.datePicker.minuteInterval = 1
cell.date = date
Expand Down