Skip to content

Hide the navigation bar on the status screen to give more vertical space #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loudnate merged 2 commits into from
Aug 28, 2016
Merged

Hide the navigation bar on the status screen to give more vertical space #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c822cfb
Hide the navigation bar on the status screen to give more vertical space
loudnate Aug 27, 2016
6b679fb
Updating the launch screen to match
loudnate Aug 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Loop/Base.lproj/LaunchScreen.storyboard
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="10117" systemVersion="15E65" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" launchScreen="YES" useTraitCollections="YES" initialViewController="c6k-8z-nla">
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="10117" systemVersion="15G31" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" launchScreen="YES" useTraitCollections="YES" initialViewController="c6k-8z-nla">
<dependencies>
<deployment identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="10085"/>
Expand All @@ -8,7 +8,7 @@
<!--Navigation Controller-->
<scene sceneID="Ucb-uj-Fzl">
<objects>
<navigationController toolbarHidden="NO" id="c6k-8z-nla" sceneMemberID="viewController">
<navigationController navigationBarHidden="YES" toolbarHidden="NO" id="c6k-8z-nla" sceneMemberID="viewController">
<tabBarItem key="tabBarItem" enabled="NO" title="" id="nfG-Bf-TrT"/>
<navigationBar key="navigationBar" contentMode="scaleToFill" id="3rC-hS-Fnr">
<rect key="frame" x="0.0" y="0.0" width="320" height="44"/>
Expand Down
4 changes: 4 additions & 0 deletions Loop/View Controllers/StatusTableViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ final class StatusTableViewController: UITableViewController, UIGestureRecognize
override func viewWillAppear(animated: Bool) {
super.viewWillAppear(animated)

navigationController?.setNavigationBarHidden(true, animated: animated)
visible = true
}

Expand All @@ -83,6 +84,9 @@ final class StatusTableViewController: UITableViewController, UIGestureRecognize
override func viewWillDisappear(animated: Bool) {
super.viewWillDisappear(animated)

if presentedViewController == nil {
navigationController?.setNavigationBarHidden(false, animated: animated)
}
visible = false
}

Expand Down