Carb entry entry comma not accepted and can lead to a large bolus by error

[yagmoth555]

Describe the bug

On the latest build the carb menu to enter it don't allow the ',' to make a carb entry like 14,5. If I enter fast I could not remark it and type 145. Thanks to the safe settings to prevent large bolus I remarked it, but for an entry like 7,5, that could end up 75, the fail safe would not protect me.

I have two kid that loop, one on previous build and one on the latest stable build, I can confirm only the latest 3.4.1 make that bug.

To Reproduce
Steps to reproduce the behavior:

1. Go to add a meal bolus
2. Click on any number, and try to select the ','.
3. The ',' button just don't input anything, so typing after just make a large bolus
4. See error in video

Expected behavior
Like the older build, it should be to enter like 14,5, and the loop round up the number.

Screenshots
See below for a video. I try to enter 2,2 to show the problem and it end up as 22.

Phone

• Hardware: [iPhone 12]
• OS Version: [iOS 17.4.1]

Loop Version

• Version Number: [3.4.1]
• Repo: [LoopKit/Loop]

CGM

• Device: [e.g. Dexcom G7]
• Manager app: [Dexcom App]

Pump

• Manufacturer: [OmniPod DASH]

Additional context

Is it a localization issue ? My iOS is in French, and I wonder if it's a comma vs period error in the dialog checkup routine.

IMG_3720.MOV

[yagmoth555]

It was indeed a localization error; but the code mostly should check that, but in the iPhone->General->Language and Country->Number format. It was in French's mode; 1 222 333,44, switched to 1 222 333.44

[Joerg-Schoemer]

there is a filter only respecting "0123456789." as possible inputs.
If we use the formatter the locale is respected and every decimal separator will work.