Skip to content

Add dynamic Map2LoopAPI #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: v3.3.0
Choose a base branch
from

Conversation

rabii-chaarani
Copy link
Member

Summary

  • implement Map2LoopAPI facade that dynamically discovers classes
  • expose Map2LoopAPI in package root
  • add regression tests for the new API

Testing

  • pytest tests/test_api.py -q (fails: ModuleNotFoundError: No module named 'osgeo')
  • pip install gdal==3.6.2 (fails: Could not find gdal-config)

https://chatgpt.com/codex/tasks/task_e_685b86747438832fa992ef294ac164d6

@rabii-chaarani rabii-chaarani requested a review from Copilot June 25, 2025 05:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a dynamic API facade, Map2LoopAPI, that discovers and instantiates classes from the map2loop package, and it provides regression tests to validate this functionality.

  • Implements Map2LoopAPI with dynamic class discovery and instantiation.
  • Exposes Map2LoopAPI at the package root for external use.
  • Adds regression tests to cover API listing, class retrieval, and instance creation.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/test_api.py Adds tests for listing available classes, retrieving classes, and creating instances.
map2loop/api.py Implements the dynamic class discovery and API facade functionality.
map2loop/init.py Exposes Map2LoopAPI in the package root.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rabii-chaarani rabii-chaarani marked this pull request as draft June 25, 2025 05:34
@rabii-chaarani rabii-chaarani changed the base branch from master to qgis/sampler-clean June 25, 2025 05:59
@rabii-chaarani rabii-chaarani changed the base branch from qgis/sampler-clean to v3.3.0 June 30, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant